ros-drivers / ros2_ouster_drivers

ROS2 Drivers for the Ouster OS-0, OS-1, and OS-2 Lidars
https://ouster.com/
Apache License 2.0
134 stars 79 forks source link

fix tf2_geometry_msgs include not found #107

Closed bertaveira closed 2 years ago

bertaveira commented 2 years ago

The commit #2d36cbd changed the include from .h to .hpp which at least for me on Galactic makes it not work. This is what i have found to be the recommended way to do it but testing on Humble would be required

bertaveira commented 2 years ago

Building on a docker of Humble seems to throw a warning of deprecated header. No error just warning.

Taking a closer look at the official documentation of humble shows that their examples also use the compilation variable TF2_CPP_HEADERS so I assume it is the correct way to keep backwards compatibility: https://docs.ros.org/en/humble/Tutorials/Intermediate/Tf2/Using-Stamped-Datatypes-With-Tf2-Ros-MessageFilter.html