Does not work with sensor on firmware v2.4

[vinnnyr]

Details / logs to come. Just a warning I wanted to post right now to users of the repo that as of the latest commit on ros2 (https://github.com/ros-drivers/ros2_ouster_drivers/commit/cdd778696dbe560699c96345aead75c5282dd93c) , to not upgrade until this is resolved, since it is not possible to revert to firmware v2.3 (they disabled the download on the website).

From what I understand, this is due to some deprecated parameters in the new firmware (auto_start_flag and udp_ip).

I am working on a fix, and will try to PR it when I have tested it against the new firmware, however I am not really sure how backwards compatible it will be.

[vinnnyr]

From Ouster, this is the patch that would work for 2.4 on their version of the driver. https://github.com/ouster-lidar/ouster_example/commit/6e3df5efcb332562c6381e5b668c6936c09d646a

@SteveMacenski would you be ok with a PR back here with the content of that diff? The only thing is that pushing for firmware 2.4 compatiblity might break compatible with earlier firmwares

[kpsgf7]

@vinnnyr Are you attempting a fix for this then? I may attempt a fix if we are unable to get v2.3 of the firmware from Ouster. Would love to contribute if that's something that would be helpful here.

[vinnnyr]

@kpsgf7 can you test this fork? https://github.com/fireflyautomatix/ros2_ouster_drivers/tree/fix-for-firmware-2.4

I currently don't have a lidar with v2.4 to test on available to me, hence my hesitation in opening the PR. I should have one available to me shortly

[vinnnyr]

I just tested this with 2 v2.4 lidars. I think that PR should be ready for review now!

[kpsgf7]

This worked for us! Thank you! We really appreciate it.