search

ros-drivers / ros2_ouster_drivers

ROS2 Drivers for the Ouster OS-0, OS-1, and OS-2 Lidars
https://ouster.com/
Apache License 2.0
134 stars 79 forks source link

_range_image resize twice? #123

Closed jonbakerfish closed 1 year ago

jonbakerfish commented 1 year ago

https://github.com/ros-drivers/ros2_ouster_drivers/blob/d59df70a6e58e646fd305cb913fa8c802fc6588c/ros2_ouster/include/ros2_ouster/processors/image_processor.hpp#L96-L99

It seems that the first resize is useless.

SteveMacenski commented 1 year ago

Agreed. I’m not sure how that got in there. Can you submit a PR to remove? Happy to merge (I’m just on the go on vacation)

jonbakerfish commented 1 year ago

Hi @SteveMacenski , just create a PR https://github.com/ros-drivers/ros2_ouster_drivers/pull/124 . Plz have a look :)

SteveMacenski commented 1 year ago

Thanks!