search

ros-drivers / ros2_ouster_drivers

ROS2 Drivers for the Ouster OS-0, OS-1, and OS-2 Lidars
https://ouster.com/
Apache License 2.0
134 stars 79 forks source link

Fix jsoncpp include/link interface #57

Closed cottsay closed 4 years ago

cottsay commented 4 years ago

It appears that Ubuntu happens to put the jsoncpp headers at /usr/include/jsoncpp/json/json.h, but it doesn't appear that is necessarily common practice. By correcting the CMake interface for jsoncpp, the /usr/include/jsoncpp directory is added to the compiler's include directory search path, allowing the header reference to be changed to the correct path, json/json.h.

In particular, Fedora places the jsoncpp header at /usr/include/json/json.h. This change allows ros2_ouster to compile successfully on both platforms.

tpanzarella commented 4 years ago

No objections.

Tom Panzarella (sent from my phone)

On Jul 27, 2020, at 9:06 PM, Steve Macenski notifications@github.com wrote:

 @SteveMacenski approved this pull request.

@tpanzarella any objection?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.