ros-drivers / ros2_ouster_drivers

ROS2 Drivers for the Ouster OS-0, OS-1, and OS-2 Lidars
https://ouster.com/
Apache License 2.0
134 stars 79 forks source link

Port FW 2.0 and 2.1 changes #75

Closed MattSYoung closed 3 years ago

MattSYoung commented 3 years ago

Based on my discussion with Steve in #74, there are features in ouster-lidar/ouster_example that have yet to be ported to this repo. I believe (and correct me if I'm wrong) that the last set of changes ported were made with #67. It looks like this PR includes all changes prior to ouster_example/#239.

The goal of this issue is to port across the minimal number of changes to maintain compatibility between the contents of ouster_example/ouster_client and the equivalent files here.

List of features/items to port include:

From ouster_example/#239

From ouster_example/#246

From ouster_example/#259

MattSYoung commented 3 years ago

@SteveMacenski Let me know if there is anything here that I've missed.

MattSYoung commented 3 years ago

I think all the changes have been ported, see https://github.com/MattSYoung/ros2_ouster_drivers. I'll do some testing with a physical Ouster and then issue a merge request from that fork.

MattSYoung commented 3 years ago

Confirmed that the changes haven't broken anything (see below). Tested with a OS0-128 at 2048x10 resolution. I will issue a PR now

image (3)

MattSYoung commented 3 years ago

Closed with the merge of #76