Closed MattSYoung closed 3 years ago
Let me know when you want me to review this again (also you have a conflict)
@SteveMacenski I'm ready for you to review the PR again.
It is feature complete, however there are still some issues with the output rate of the /points
topic depending on the throughput/replay rate of the incoming packets. This is mostly an issue with the high-rate OS0-128 that I have access to, and may not be an issue at all for other Ouster models. In most cases this simply means the output rate of the /points
topic will be as low as 3.5 Hz instead of the target 10 or 20 Hz.
Since this is fundamentally an issue with the replay rate/throughput of the user's ethernet device, and not the Tins based driver, I would rather address this problem separately in issue #78.
Did you compile with release flags? that's often a quick fix of such issues others have reported.
Looks like you have some new merge conflicts. I'm doing another pass through the code, but so far the only thing is the linting in the non-client files
Once the conflicts / linting is done, happy to merge it!
Ok, after navigating the minefield that is git rebase
, I think we're good to go. I will run one last QA/bug check tomorrow and then let you know it's ready to merge.
General Changes
::onConfigure()
function of each sensor implementation.TinsDriver