search

ros-drivers / ros2_ouster_drivers

ROS2 Drivers for the Ouster OS-0, OS-1, and OS-2 Lidars
https://ouster.com/
Apache License 2.0
134 stars 79 forks source link

Add parameter to change azimuth window #98

Closed bertaveira closed 2 years ago

bertaveira commented 2 years ago

I don't think I am the only one using this configuration of the azimuth window. Previously we would set it through the web configurator and then it would be saved but on recent firmware versions it sometimes resets to 0-360 azimuth window which is unfortunate.

Therefore I made so that there is a parameter and the ROS driver sets this parameter as well.

bertaveira commented 2 years ago

tested on OS1-64 FW 2.2.1 on ROS foxy

SteveMacenski commented 2 years ago

Any modifications to the client code needs to be merged into the ouster example library first before here, that way they remain in sync and when updates are pushed there, they can be easily migrated here. Please submit the client-modifying code there and have it merged first, then reopen here and we can make quick work of it.

bertaveira commented 2 years ago

PR waiting for approval on the ouster_example. Hopefully soon we can port it here ouster-lidar/ouster_example#366