search

ros-drivers / ros2_ouster_drivers

ROS2 Drivers for the Ouster OS-0, OS-1, and OS-2 Lidars
https://ouster.com/
Apache License 2.0
134 stars 79 forks source link

Fix up warnings and errors from latest Rolling releases. #99

Closed clalancette closed 2 years ago

clalancette commented 2 years ago

This cleans up two problems:

  1. rclcpp no longer accepts bare "declare_parameters" without a type, so add an empty string by default.
  2. The tf2_geometry_msgs headers all should now use the .hpp suffix, so fix that as well.

This should allow this package to build without warnings on the buildfarm.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This should fix the failing builds, like in https://build.ros2.org/view/Rbin_uJ64/job/Rbin_uJ64__ros2_ouster__ubuntu_jammy_amd64__binary/

SteveMacenski commented 2 years ago

Thanks!

SteveMacenski commented 2 years ago

I'll run a sync with Rolling on Friday with some other packages. I haven't done a full sync across Nav2 in a long time now

clalancette commented 2 years ago

I'll run a sync with Rolling on Friday with some other packages. I haven't done a full sync across Nav2 in a long time now

Perfect, thanks!