ros-drivers / rosserial

A ROS client library for small, embedded devices, such as Arduino. See: http://wiki.ros.org/rosserial
508 stars 526 forks source link

[Windows] use c++ signed trait to replace ssize_t for better portability. #463

Closed seanyen closed 4 years ago

seanyen commented 4 years ago

The ssize_t is a type defined in POSIX standard. However, on non-POSIX system (for example, Windows), this could be absent.

This change is inspired by an alternative being talked about in this conclusion: LWG issue: 2251. C++ library should define ssize_t, which mentions that this can be achieved by C++11 type trait feature.

seanyen commented 4 years ago

@mikepurvis This is ready for review and merge. Thanks!

mikepurvis commented 4 years ago

Great, thanks!