search

ros-drivers / rosserial

A ROS client library for small, embedded devices, such as Arduino. See: http://wiki.ros.org/rosserial
517 stars 525 forks source link

Feature/noetic python support #508

Closed asukiaaa closed 4 years ago

asukiaaa commented 4 years ago

The commits are cherry picked by theseankelly to noetic-turtlebot branch branch from gcc7-fixes branch.

mikepurvis commented 4 years ago

I guess this is still an omnibus in the way that #480 was, but at this point pragmatism should carry the day. Please also re-enable the python_socket test here, and if that passes clean on Noetic CI, then we're good to go:

https://github.com/ros-drivers/rosserial/blob/04ddab73643e617910cbfdfe6dcf60476385bffe/rosserial_test/CMakeLists.txt#L47

asukiaaa commented 4 years ago

Thank you for the information. I merged your commit to my branch asukiaaa:feature/noetic-python-support to activate test. Could you create PR to my(asukiaaa's) branch not to mikepurvis's branch on next?

asukiaaa commented 4 years ago

Thank you for checking and merging.

mikepurvis commented 4 years ago

Thank you for the work rebasing this branch and putting up the PR.