ros-drivers / rosserial

A ROS client library for small, embedded devices, such as Arduino. See: http://wiki.ros.org/rosserial
508 stars 527 forks source link

Use std::memcpy instead of void casts. #509

Closed mikepurvis closed 3 years ago

mikepurvis commented 3 years ago

As suggested by @stertingen in https://github.com/ros-drivers/rosserial/pull/508#pullrequestreview-472397249. This behaviour is covered by a test (thanks @PetteriAimonen for the work on that), so I think the only possible regression could be around the addition of #include <cstring>; basically, this should be safe.