search

ros-drivers / rosserial

A ROS client library for small, embedded devices, such as Arduino. See: http://wiki.ros.org/rosserial
517 stars 525 forks source link

Remove "override" mark form "ServiceClient::call()" function #522

Closed tongtybj closed 2 years ago

tongtybj commented 4 years ago

ServiceClient::call () does not have a virtual function in Subscriber_, so remove the override mark.

tongtybj commented 4 years ago

Also exclude theServiceClient instance in unregistration process, otherwise following error will occur:

Traceback (most recent call last):
  File "/root/ros/rosserial_ws/devel/lib/rosserial_python/serial_node.py", line 15, in <module>
    exec(compile(fh.read(), python_script, 'exec'), context)
  File "/root/ros/rosserial_ws/src/rosserial/rosserial_python/nodes/serial_node.py", line 72, in <module>
    server.listen()
  File "/root/ros/rosserial_ws/src/rosserial/rosserial_python/src/rosserial_python/SerialClient.py", line 251, in listen
    self.startSerialClient()
  File "/root/ros/rosserial_ws/src/rosserial/rosserial_python/src/rosserial_python/SerialClient.py", line 272, in startSerialClient
    srv.unregister()
AttributeError: 'ServiceClient' object has no attribute 'unregister'