search

ros-drivers / rosserial

A ROS client library for small, embedded devices, such as Arduino. See: http://wiki.ros.org/rosserial
517 stars 525 forks source link

Use shutil.copyfile() instead of shutil.copy() #530

Closed lopsided98 closed 3 years ago

lopsided98 commented 3 years ago

On my distribution, rosserial's files are installed readonly, and shutil.copy() preserves this when copying them. The causes make_libraries to fail the next time it runs as it tries to overwrite the readonly files. shutil.copyfile() does not preserve the permissions, preventing this problem.

mikepurvis commented 3 years ago

Awesome, thanks for the easy fix.