examples/ADC/ADC.pde: rosserial_arduino -> rosserial_mbed

ros-drivers / rosserial

A ROS client library for small, embedded devices, such as Arduino. See: http://wiki.ros.org/rosserial

508 stars 527 forks source link

examples/ADC/ADC.pde: rosserial_arduino -> rosserial_mbed #546

Closed s-t-a-n closed 3 years ago

s-t-a-n commented 3 years ago

rosserial_arduino/src/ros_lib/examples/ADC/ADC.pde does not compile. It seems that the ADC components in rosserial_arduino were recently moved to rosserial_mbed. Changing rosserial_arduino to rosserial_mbed does the trick.

Tested with:

Arduino IDE 1.8.13
Arduino-CI 1.3

ROSserial headers generated from noetic-devel using:

python-pyserial 3.5-1
ros-noetic-roscpp-serialization 0.7.1-1

romainreignier commented 3 years ago

Mbed and Arduino are distinct frameworks, there is no point to mix the two. The Adc.msg file has not been changed for 10 years. The issue is elsewhere.

s-t-a-n commented 3 years ago

The problem seems to be in the call to catkin_python_setup() in rosserial_arduino/CMakeLists.txt. Commenting it yields the generation of the rosserial_arduino messages.

I'll have a further look into it.

s-t-a-n commented 3 years ago

Ah luckily someone already found out what's bugging: #519

This is related to #504, and is fixed by #521

I can confirm this is fixed by #521

romainreignier commented 3 years ago

Thanks for digging into the issue.