search

ros-drivers / rosserial

A ROS client library for small, embedded devices, such as Arduino. See: http://wiki.ros.org/rosserial
517 stars 525 forks source link

node_handle: spinOnce: add two new return codes #556

Closed alonblade closed 3 years ago

alonblade commented 3 years ago

Adds two new return codes (backward compatible change):

SPIN_TX_STOP_REQUESTED SPIN_TIME_RECV

They are returned as the name suggests to differentiate two states in which currently SPIN_OK would have been returned.

This allows the caller to further use the return, i.e. issuing a log message (that is always sent irrespective of connected status since ID < 100).

Signed-off-by: Alon Levy alon.levy@bladeranger.com

alonblade commented 3 years ago

@mikepurvis Hi, sorry for the noise - I'm not sure who to ask about this PR, so I just picked you since you did the last release (per the commit log)? Is this something you would consider including? Thanks,

Alon

mikepurvis commented 3 years ago

Yes, sorry for the delay. My day job no longer actively uses this repo, so my maintenance of it comes in fits and starts.

This looks like a reasonable change, thanks.