search

ros-drivers / rosserial

A ROS client library for small, embedded devices, such as Arduino. See: http://wiki.ros.org/rosserial
517 stars 525 forks source link

Remove ESP flags for ArduinoTcpHardware to use hardware serial #559

Closed asukiaaa closed 3 years ago

asukiaaa commented 3 years ago

I want to use HardwareSerial with ESP32. Could you consider removing ESP flags to activate ArduinoTcpHardware?

Thanks.

romainreignier commented 3 years ago

If the serial path works without any more changes, this seems ok but the esp8266 example should be changed to add the ROSSERIAL_ARDUINO_TCP define at the top.

asukiaaa commented 3 years ago

Thank you for the feedback. I checked ROSSERIAL_ARDUINO_TCP flag enables tcp on ESP32 and ESP32 can use hardware serial without it.

mikepurvis commented 3 years ago

This seems reasonable and non-breaking. Thanks for the change.