search

ros-drivers / transport_drivers

A set of ROS2 drivers for transport-layer protocols.
Apache License 2.0
92 stars 56 forks source link

Adding Foxy build to CI. #20

Closed JWhitleyWork closed 4 years ago

JWhitleyWork commented 4 years ago

Since we're now releasing for Foxy, we should build and test it there too.

JWhitleyWork commented 4 years ago

Given that it's practically the same job, we can reuse most of it with the strategy clause for GitHub actions:

Thanks for the suggestion! Implemented.

esteve commented 4 years ago

@JWhitleyWork I've updated the PR with the change I suggested (https://github.com/ros-drivers/transport_drivers/pull/20/commits/7179a26d1dda7a31a77bbc8e99caba8bb25449ea). I believe it looks cleaner and more streamlined, feel free to revert it you'd rather keep the previous style.

JWhitleyWork commented 4 years ago

I thought the way you did it would create 4 jobs but I guess not.