ros-drivers / transport_drivers

A set of ROS2 drivers for transport-layer protocols.
Apache License 2.0
92 stars 56 forks source link

Make Nodes Component-Compatible #21

Closed JWhitleyWork closed 3 years ago

JWhitleyWork commented 3 years ago

The SerialDriverNode and UdpDriverNode, as currently designed, do not pass an rclcpp::NodeOptions object and they also (unnecessarily) take in namespace data. Additionally, there are constructors which will not be necessary once the constructors which take an rclcpp::NodeOptions object are created.