Closed flynneva closed 3 years ago
Before this, let me apply some simplifications that will make CMakeLists.txt easier to work with.
@flynneva Re-base your branch on main
now. CMakeLists.txt should be a little easier to put together with ament_cmake_auto
.
FYI - except for Boost (and other system dependencies), ament_auto_find_build_dependencies()
will automatically gather all dependencies from package.xml
and add their include directories and libraries to every executable added with ament_auto_add_executable
and ament_auto_add_library
. It will also automatically export an include
directory from a package (if found) with ament_auto_package()
.
FYI - except for Boost (and other system dependencies), ament_auto_find_build_dependencies() will automatically gather all dependencies from package.xml and add their include directories and libraries to every executable added with ament_auto_add_executable and ament_auto_add_library. It will also automatically export an include directory from a package (if found) with ament_auto_package().
way cool. i had no idea. good info! ill rebase with your updates and see if i can clean up the CMakelists
ok i think i got it using the ament_auto
macros @JWhitleyWork
@JWhitleyWork had a few cmake lint errors after switching to ament_auto_lint
. let me know if you see anything else!
wow sorry I just realized that I definitely should've just added another commit rather than force pushing the changes you requested. That's my fault, sorry 😅
so i think i got it working since all tests are passing and its compiling. probably doing something wrong in the
CMakelists
though.this should set us up to be able to use the
io_context
in theserial_driver
as well now