search

ros-drivers / transport_drivers

A set of ROS2 drivers for transport-layer protocols.
Apache License 2.0
92 stars 56 forks source link

move io_context to shared lib #36

Closed flynneva closed 3 years ago

flynneva commented 3 years ago

so i think i got it working since all tests are passing and its compiling. probably doing something wrong in the CMakelists though.

this should set us up to be able to use the io_context in the serial_driver as well now

JWhitleyWork commented 3 years ago

Before this, let me apply some simplifications that will make CMakeLists.txt easier to work with.

JWhitleyWork commented 3 years ago

@flynneva Re-base your branch on main now. CMakeLists.txt should be a little easier to put together with ament_cmake_auto.

JWhitleyWork commented 3 years ago

FYI - except for Boost (and other system dependencies), ament_auto_find_build_dependencies() will automatically gather all dependencies from package.xml and add their include directories and libraries to every executable added with ament_auto_add_executable and ament_auto_add_library. It will also automatically export an include directory from a package (if found) with ament_auto_package().

flynneva commented 3 years ago

FYI - except for Boost (and other system dependencies), ament_auto_find_build_dependencies() will automatically gather all dependencies from package.xml and add their include directories and libraries to every executable added with ament_auto_add_executable and ament_auto_add_library. It will also automatically export an include directory from a package (if found) with ament_auto_package().

way cool. i had no idea. good info! ill rebase with your updates and see if i can clean up the CMakelists

flynneva commented 3 years ago

ok i think i got it using the ament_auto macros @JWhitleyWork

flynneva commented 3 years ago

@JWhitleyWork had a few cmake lint errors after switching to ament_auto_lint. let me know if you see anything else!

flynneva commented 3 years ago

wow sorry I just realized that I definitely should've just added another commit rather than force pushing the changes you requested. That's my fault, sorry 😅