search

ros-drivers / transport_drivers

A set of ROS2 drivers for transport-layer protocols.
Apache License 2.0
93 stars 56 forks source link

Remove deprecated api from galactic #57

Closed wep21 closed 3 years ago

wep21 commented 3 years ago

Remove deprecated api for declare_parameter from galactic to suppress build warnings.

wep21 commented 3 years ago

@JWhitleyWork Could you review this?

JWhitleyWork commented 3 years ago

Since Galactic was only just released today and isn't yet supported in ros-tooling CI jobs, I'd like to hold this until that is complete.

wep21 commented 3 years ago

@JWhitleyWork I think these changes cause a build error on foxy, could you create galactic branch?

JWhitleyWork commented 3 years ago

@wep21 Please rebase your branch on main and you should get an updated Github Actions config file which will only runn for galactic and rolling on that branch.

JWhitleyWork commented 3 years ago

Nevermind. I applied the rebase. Once CI passess, I'll merge this and release for Galactic and Rolling.