search

ros-drivers / urg_node

ROS wrapper for the Hokuyo urg_c library.
Other
101 stars 147 forks source link

Add new status information #109

Open splatter96 opened 1 year ago

splatter96 commented 1 year ago

This MR adds the ability to output the current warning and OSSD states the scanner calculates and transmits as part of the AR00 message. This is necessary to be able to use the scanner for any safety setup.

This MR relies on https://github.com/ros-drivers/urg_node_msgs/pull/6 to be merged first.

splatter96 commented 1 year ago

The checks curently fail, because the needed changes for the urg_node_msgs package are not yet in the official repos, which the jenkins bot relies on? Is there any way to use the current github master of that repo for the jenkins checks?

mikeferguson commented 1 year ago

Still working towards a release of the update to messages - we shouldn't change the message in released distros (Humble/Iron) so I needed up branch off for a rolling release. Still waiting for that PR to be merged in rosdistro, and then I will do a new message package release.

mikeferguson commented 1 year ago

https://github.com/ros/rosdistro/pull/37629 is the release for urg_node_msgs - now we have to wait for that to be merged, built and synced, and then this should pass.

splatter96 commented 1 year ago

I pushed an empty commit to retrigger the actions and seems there are atleast no errors in those. Can you have a look if it is possible to merge this @mikeferguson ?

splatter96 commented 1 year ago

@mikeferguson did you have time to check the MR in the meantime? :)