search

ros-drivers / velodyne

ROS support for Velodyne 3D LIDARs
http://ros.org/wiki/velodyne
Other
646 stars 643 forks source link

request to make ip-address configurable when starting with launch file #463

Closed floriankittelmann closed 2 years ago

floriankittelmann commented 2 years ago

Describe the solution you'd like My LiDAR sensor runs on a different ip-address than 192.168.1.201 and I start usually the node on ros2 foxy by calling the launch file like that: ros2 launch velodyne velodyne-all-nodes-VLP32C-launch.py. I saw that the ip-address is configured in the yaml file and I would like to change this default-parameter by calling something like that: ros2 launch velodyne velodyne-all-nodes-VLP32C-launch.py device_ip:=<other ip address>

Describe alternatives you've considered In the moment I go to the settings of the lidar and change the ip-address to 192.168.1.201. This works, but I think the ip-address should be configurable in the ros node easily. I also considered to change the yaml file, but I dont see that good practice, because I don't build the source code by myself and I install the package via sudo apt..

JWhitleyWork commented 2 years ago

This is pretty easy to do by making it a launch file argument. Please feel free to make a Pull Request with this change and I would be happy to review it.