search

ros-drivers / velodyne

ROS support for Velodyne 3D LIDARs
http://ros.org/wiki/velodyne
Other
646 stars 643 forks source link

feat: support vls128 for ros2 #493

Closed wep21 closed 1 year ago

wep21 commented 1 year ago

ros2 port for #370, #382, #413

wep21 commented 1 year ago

@clalancette @JWhitleyWork Could you review this PR?

JWhitleyWork commented 1 year ago

Has this been tested on real hardware?

wep21 commented 1 year ago

Not yet. I will test on real sensor.

Mtestor commented 1 year ago

I have tested and it doesn't work. I have modified it to work. Do i open a pull request too ?

wep21 commented 1 year ago

@Mtestor Thank you for testing. Could you create a PR to my branch?

Mtestor commented 1 year ago

sure

Mtestor commented 1 year ago

@wep21 your branch doesn't appear when i try to pull request.

wep21 commented 1 year ago

@Mtestor You mean you cannot find my branch even when creating a PR from my fork?

Mtestor commented 1 year ago

Thanks ! I have done a PR.

JWhitleyWork commented 1 year ago

Rebased on current ros2 branch, which includes updated CI job.