search

ros-drivers / velodyne

ROS support for Velodyne 3D LIDARs
http://ros.org/wiki/velodyne
Other
646 stars 643 forks source link

Fix time_offset units #531

Closed nachovizzo closed 6 months ago

nachovizzo commented 11 months ago

time_offset is specified everywhere to be in seconds. Probably something that was ported from the ROS 1 implementation. In the changed line, the summation was done in nanoseconds, and therefore, the maximum time offset one could add was just 1.0 nanoseconds

Done in Collaboration with @doisyg

nachovizzo commented 6 months ago

Closing this due to lack of activity :) feel free to reopen if needed