Open kunaltyagi opened 6 years ago
Hello. Sorry for the late reply, I was away for a few weeks. Thank you very much for your efforts.
As you say... this is mainly a complete rewrite. I don't feel confident merging it. At least we'd need to test every old possible use case to make sure it still works as before. Said that, I have the following concerns:
About CMake 3.1, Ubuntu 14.04 has version 2.8.12.2, and this package is supported on ROS Indigo, so I would rather not merge that. Is it really necessary?
About C++11, I'm not a C++ expert, so I don't know if that has any backwards compatibility problems either.
I do like the capability of looping and also pausing the play. Couldn't that be implemented in the previous code base?
Regarding the versions
-std=c++11
in the best practices. We can always use set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
indigo-devel
for indigo, and master for the rest?)Regarding the refactor:
TLDR: This PR is just a refactor with minor changes. Makes it easier for developers, but not required to be merged upstream. The minor changes can be cherry-picked and merged.
This code uses C++11 and CMake 3.1. I don't know what the compatibility requirements are. If you are not able to merge this, no issues.
Modified the code to have the following: