search

ros-drivers / video_stream_opencv

A package to open video streams and publish them in ROS using the opencv videocapture mechanism
227 stars 159 forks source link

Add loop param for videofile #24

Closed iory closed 5 years ago

iory commented 6 years ago

This PR adds a loop rosparam for videofile. if loop is true, this node keeps publishing image all the time.

Carter12s commented 5 years ago

Asking for a bump on merging this!

awesomebytes commented 5 years ago

Hello @iory. Sorry for the long delay. I'd gladly merge your changes but I need you to update the documentation too.

But first I would like to ask you if you can change the parameter name from loop to loop_videofile to make even more clear what it does.

That implies updating with your loop_videofile param:

Thank you a lot for your PR tho!

iory commented 5 years ago

Thank you for your response! I modified variable name loop to loop_videofile and also add launch file and README's comment and roswiki page. Please check it.

awesomebytes commented 5 years ago

Merged, thank you :) I'm going to check out another PR and I'll re-release the package soon.

iory commented 5 years ago

Thank you!