Fix Node sending last frame on camera crash

ros-drivers / video_stream_opencv

A package to open video streams and publish them in ROS using the opencv videocapture mechanism

227 stars 159 forks source link

Fix Node sending last frame on camera crash #27

Closed SudeepDasari closed 5 years ago

SudeepDasari commented 5 years ago

I've noticed the node will continuously send the last frame pulled from the camera in the event of a hardware error/disconnect. This is very undesirable for my use-case (and I suspect many others). It may have something to do with this issue, although I haven't tested.

I've fixed this behavior, and now the node will automatically exit out when the camera disconnects/crashes.

awesomebytes commented 5 years ago

Hello, I'm sorry I didn't accept your PR but I think the best way is to throw a runtime exception if this happens. I implemented that here: https://github.com/ros-drivers/video_stream_opencv/commit/709213dc9a9c2b89dc2d366afb0a8bffe1714ba4

I'll release a new version of the package soon.