Closed furushchev closed 5 years ago
This is great, I surely want it included, but, could you quickly explain me what happens if you change the config dynamically to something that's wrong?
Say you write a provider that does not exist (a file that doesnt exist for example or video device that errors). My previous experience with nodelets having problems and hanging has me a bit worried. I trust you've tried it, but I'd like a confirmation :)
Thank you!
@awesomebytes You are totally right, changing provider dynamically did not work. VideoCapture.open
method never returns so we should not make the value dynamic-reconfigurable.
The other parameters are ok to be changed dynamically.
I updated this PR to get video_stream_provider
from rosparam.
This PR is based on #33 and add support for setting parameters dynamically.