search

ros-drivers / video_stream_opencv

A package to open video streams and publish them in ROS using the opencv videocapture mechanism
227 stars 159 forks source link

Add option to set output_encoding #50

Closed furushchev closed 5 years ago

furushchev commented 5 years ago

This PR overrides https://github.com/ros-drivers/video_stream_opencv/pull/47 to support all available output encoding.

J-Rojas commented 5 years ago

Thanks for looking into this. I didn't know there were encoding strings already available to cvbridge. Where are these documented? Maybe add a comment to the code with a link to where those are defined in CvBridge for now until the formal documentation is updated?

furushchev commented 5 years ago

@J-Rojas Added a link to the definition.