search

ros-drivers / video_stream_opencv

A package to open video streams and publish them in ROS using the opencv videocapture mechanism
227 stars 159 forks source link

Upgrade to OpenCV 4 #53

Closed leoll2 closed 4 years ago

leoll2 commented 4 years ago

I renamed few constants that changed in OpenCV 4, my repo is now compatible with that version (but no longer with OpenCV 3). So, I invite you to create a new branch 'opencv4' where to merge this pull request. Thanks

furushchev commented 4 years ago

@leoll2 Thank you for your contribution! As far as I see the changes, it looks it should work both on OpenCV 3 and 4. (And the testing on travis passed successfully.)

leoll2 commented 4 years ago

Cool, I didn't expect it to still work in opencv 3. It's curious how they provide forward compatibility, but not backward :) Anyway, thanks for merging.