search

ros-drivers / video_stream_opencv

A package to open video streams and publish them in ROS using the opencv videocapture mechanism
227 stars 159 forks source link

get canonical file for target device #60

Closed mjsobrep closed 4 years ago

mjsobrep commented 4 years ago

59 was being caused because a symlink to the dev/videoX location does not get red properly as a character or block type file. The solution is to get the canonical path (no symlinks, no ..) before testing the file.

On some newer versions of boost, this seems to not be a problem? But getting the canonical path would seem to always be a good thing.

mjsobrep commented 4 years ago

Want to check back in on this. Any thoughts?

awesomebytes commented 4 years ago

This looks good to me. Looks like a safe change that can only provide benefits.

@furushchev what do you think?

furushchev commented 4 years ago

@mjsobrep @awesomebytes I'm sorry for the late reply. This looks totally good to me! I'll merge it.