search

ros-drivers / video_stream_opencv

A package to open video streams and publish them in ROS using the opencv videocapture mechanism
224 stars 159 forks source link

add clockwise image rotation #88

Open NescobarAlopLop opened 3 years ago

furushchev commented 3 years ago

Thank you for the contribution! I think you can get rotated images by any degrees by combining this node and image_rotate node. Please check the documentation:http://wiki.ros.org/image_rotate

NescobarAlopLop commented 3 years ago

In my case running another node was not an option, so I thought I might not be alone. Thank you for the suggestion, I'll definitely use image_rotate in future products.

So are you interested in this feature, should I improve on anything or just close the PR?

awesomebytes commented 3 years ago

If we were to support this I'd rather be able to rotate the image in all the available rotations from Opencv:

  cv::ROTATE_90_CLOCKWISE = 0,
  cv::ROTATE_180 = 1,
  cv::ROTATE_90_COUNTERCLOCKWISE = 2

I see its usefulness, though. If you add that, I'd be happy to merge.