search

ros-gbp / csm-release

ROS Release repository for CSM, a 3rd party package that is depended from laser_scan_matcher
0 stars 2 forks source link

Release for kinetic #3

Closed stwirth closed 7 years ago

stwirth commented 7 years ago

Hi, could we get a release for kinetic please? Code seems to compile fine (with some warnings) on Ubuntu 16.04/kinetic. Thanks!

k-okada commented 7 years ago

@stwirth ok, done -> https://github.com/ros/rosdistro/pull/14128

stwirth commented 7 years ago

Awesome, thanks!

130s commented 7 years ago

@k-okada If you could share how to make a release of this package I can handle the release in the future. I tried, but I'm not familiar with this specific type of 3rd party release setting.

(There seems to be a few newer commits since 1.0.2 was made back in 2015 btw https://github.com/AndreaCensi/csm/commits/master)

k-okada commented 7 years ago

I just ran bloom-release --rosdistro kinetic --track kinetic

-- ◉ Kei Okada

2017-03-09 5:15 GMT+09:00 Isaac I.Y. Saito notifications@github.com:

@k-okada https://github.com/k-okada If you could share how to make a release of this package I can handle the release in the future. I tried, but I'm not familiar with this specific type of 3rd party release setting.

(There seems to be a few newer commits since 1.0.2 was made back in 2015 btw https://github.com/AndreaCensi/csm/commits/master)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tork-a/csm-release/issues/3#issuecomment-285155749, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3KVGa_ihBJjtfWWveUsMgyU12Verks5rjwxmgaJpZM4MWS06 .

130s commented 7 years ago

Unfortunately csm keeps failing on ROS buildfarm so I requested to revert for now https://github.com/ros/rosdistro/pull/14154

Someone seems have been able to be able to build csm on Kinetic. If someone can try patching the upstream repo that'll be great.

k-okada commented 7 years ago

fixed , see https://github.com/ros/rosdistro/pull/14156 From quick look, error on build firm (http://build.ros.org/job/Kbin_uX64__csm__ubuntu_xenial_amd64__binary/5/console) may not related post in answers.ros.org we need https://github.com/tork-a/csm-release/commit/d4b2cd84b709c53d32c4aae9b6e1be8bbbcba163

130s commented 7 years ago

Thank you for the immediate response. It seems building now!