search

ros-gbp / ompl-release

8 stars 10 forks source link

bump patch-level for ompl release, add missing pkg-config dependency #8

Closed mamoll closed 7 years ago

mamoll commented 7 years ago

Hopefully, this it not too late for the lunar release.

This PR doesn't add python bindings, but I believe enabling the python bindings is as simple as adding these build steps:

# install extra dependencies:
sudo apt-get -y install python-dev python-pip castxml
sudo -H pip install -vU pygccxml https://bitbucket.org/ompl/pyplusplus/get/1.8.0.tar.gz
# configure
cmake ... <default bloom args>
# build
make update_bindings all

I am not sure how this can be done with bloom. Installing dependencies via pip is probably frowned upon...

@130s, any thoughts?

tfoote commented 7 years ago

Yes, pip is not something that can be a dependency of a released package. However I'll note that it looks like pygccxml is available from debian packages: http://packages.ubuntu.com/trusty/python/python-pygccxml

In xenial it's still on 1.0 but as of yakkety it's available with 1.8.

mamoll commented 7 years ago

Even if pygccxml is available as a debian package, the pyplusplus package is still horribly outdated. I've been trying to take over maintainership of this package on PyPI for over a year, to no avail: https://sourceforge.net/p/pypi/support-requests/566/. Since pygccxml and pyplusplus are both only build dependencies for the python bindings, I could also do something like:

wget -O - https://github.com/gccxml/pygccxml/archive/v1.9.0.tar.gz | tar zxf - && cd pygccxml-1.9.0 && python setup.py install --user
wget -O - https://bitbucket.org/ompl/pyplusplus/get/1.8.0.tar.gz | tar zxf - && cd ompl-pyplusplus-5caf5ad8ce28 && python setup.py install --user

In any case, since the Python bindings are not that critical for MoveIt!, let's just leave this for a future ROS release.