search

ros-geographic-info / geographic_info

ROS packages for geographic information
http://ros.org/wiki/geographic_info
60 stars 61 forks source link

add missing dependency to catkin_package() #13

Closed roehling closed 9 years ago

roehling commented 9 years ago

Message generation depends on geometry_msgs, thus this dependency must be propagated in catkin_package().

jack-oquin commented 9 years ago

Thanks, Timo! Good catch.

mikepurvis commented 9 years ago

Doesn't this only affect linking? I thought a build_depend/run_depend was sufficient for messages, since they're header-only.

jack-oquin commented 9 years ago

The catkin API how-to recommends it, so it seems better to do it that way.

It does currently seem to work without the explicit find_package() component.