search

ros-geographic-info / geographic_info

ROS packages for geographic information
http://ros.org/wiki/geographic_info
60 stars 61 forks source link

Add stamped messages for GeoPoint and GeoPose. #16

Closed dornhege closed 7 years ago

mikepurvis commented 7 years ago

LGTM.

I'll give a day in case @jack-oquin or others have concerns.

jack-oquin commented 7 years ago

LGTM.

What are your feelings about release distros? Under traditional maintenance guidelines, we would not add new messages to an old distro like Indigo, but could probably still add them to Kinetic.

Given the long-term support posture of Indigo and the low risk involved in this update, I'd consider making an exception and releasing it there, too.

mikepurvis commented 7 years ago

For just adding stuff, it's a zero-risk thing, so I see no reason not to push a change like this out across the board.

dornhege commented 7 years ago

+1, we actually use this in indigo.

jack-oquin commented 7 years ago

No problem. I agree. I just didn't want to make that decision without any discussion.

If we release it to Indigo and Kinetic, I'll try to support Jade as well, assuming it's still possible to make a Jade release. I think it is.

jack-oquin commented 7 years ago

This seems like something we would have had in the beginning, if anybody had asked for it.