search

ros-geographic-info / geographic_info

ROS packages for geographic information
http://ros.org/wiki/geographic_info
60 stars 60 forks source link

geodesy: remove deprecated geodesy.gen_uuid module #4

Closed jack-oquin closed 9 years ago

jack-oquin commented 11 years ago

Take it out before release version 1.0.0.

jack-oquin commented 9 years ago

I think version 1.0.0 is still a long ways off. This was originally intended for Hydro, but not fixed then.

Since Indigo just came out, we can either:

I have no idea if anyone is actually using gen_uuid. The unique_identifier packages have been out for several releases now.

@roehling, @mikepurvis: what do you recommend?

mikepurvis commented 9 years ago

We have a dependency on gesodesy for UTM conversions, nothing to do with UUID. I'm happy to see either. Would prefer a release with no change than too much more of a wait.

jack-oquin commented 9 years ago

It is already been released with only your C++ language fix.

I would like to make another Indigo release to at least log a deprecation warning if those obsolete functions get called.

roehling commented 9 years ago

We do not use geodesy.gen_uuid either.

I generally dislike sudden and unannounced interface changes. But geodesy.gen_uuid.generate(url,id) is essentially the same as unique_id.fromURL(url+str(id)), geodesy.gen_uuid.makeUniqueID(url,id) is equivalent to unique_id.toMsg(unique_id.fromURL(url+str(id))), and neither is a core function of the package, so I think it's okay to remove it now and be done with it.

jack-oquin commented 9 years ago

Timo, I agree with both of your statements: that sudden removal is generally a bad idea, and that it is OK in this case.

The unique_id alternative has been available since Fuerte, and is quite stable, whereas this package was clearly labelled "experimental".

jack-oquin commented 9 years ago

geographic_info-0.4.0 released with this change