Fully working ROS2 update (bouncy-crystal)

ros-geographic-info / unique_identifier

ROS support for Universally Unique Identifiers

16 stars 19 forks source link

Fully working ROS2 update (bouncy-crystal) #13

Closed stonier closed 4 years ago

stonier commented 5 years ago

This supercedes what is on the current ros2 branch and the incoming PR #12 which do not yet get to the point of having everything buttoned up (notably the c++ compile).

[x] messages
[x] c++ header library
[x] c++ tests
[x] python package
[x] python tests
[x] Revamped the CMake to use CMake 3.x mechanisms while upgrading
[x] [REMOVED] metapackage (since ament doesn't support it out of the box)

@jack-oquin are you planning to do releases for this?

stonier commented 5 years ago

This is also compiling off master (soon to be crystal)

stonier commented 5 years ago

And hope life is treating you well @jack-oquin. Been a while since our beards have crossed!

SteveMacenski commented 4 years ago

@stonier with the state of the UUID library in the ros2 org, should the ros2 branch here be deleted such that there's no overlap/confusion?

stonier commented 4 years ago

@stonier with the state of the UUID library in the ros2 org, should the ros2 branch here be deleted such that there's no overlap/confusion?

Yeah, sounds like we should at least close this PR so there isn't the confusion of what direction it's heading in. Should leave the breadcrumbs here though...do you know if ros2 has the c++ header library packaged yet, or is it just the message interfaces?

Official ROS2 Message Interfaces
Official ROS2 C++ Header Library .... not yet ported

SteveMacenski commented 4 years ago

I think it's just the messages right now

stonier commented 4 years ago

Should probably get https://github.com/ros2/unique_identifier closed too if it's not the official direction.

SteveMacenski commented 4 years ago

Yeah I have a discussion here about that https://github.com/ros2/unique_identifier_msgs/issues/4