search

ros-industrial-attic / fermi

Google Summer of Code Project: Cartesian Path Planner MoveIt Plug-in
Apache License 2.0
41 stars 33 forks source link

Consider name change for Rviz panel #7

Closed shaun-edwards closed 10 years ago

shaun-edwards commented 10 years ago

The Rviz panel name is "AddWayPoint". We should consider updating the name to the proprer naming convention (i.e. Add Way Point) or giving it a more appropriate name since it does more than just add waypoints at this stage.

rkojcev commented 10 years ago

changed the name to: MoveIt Cartesian Path Planner

gavanderhoorn commented 10 years ago

changed the name to: MoveIt Cartesian Path Planner

To me this sounds like you are adding a planner to MoveIt: one that does Cartesian planning. Perhaps add a noun to more precisely convey the fact that this is 'just' an RViz panel UI to the existing planning?

rkojcev commented 10 years ago

Good suggestion, thanks

gavanderhoorn commented 10 years ago

The RViz plugin is still called "MoveIt Cartesian Path Planner" right? We don't feel this is a misnomer anymore?

rkojcev commented 10 years ago

I have renamed the plugin to: Cartesian Path Planner MoveIt Plug-in. Is this name more appropriate?

gavanderhoorn commented 10 years ago

Well, the name still does not reflect the fact that it is 'only' an RViz plugin, which provides UI to interact with the existing Cartesian planning support in MoveIt.

As far as I know, you haven't implemented a new MoveIt Cartesian planner plugin, am I right?

rkojcev commented 10 years ago

No this plugin uses the existing MoveIt Cartesian plugin. But it also uses RQT so its not only RViz... How about renaming it into: Cartesian Path Planner MoveIt UI?

rkojcev commented 10 years ago

I meant: UI for MoveIt Cartesian Path Planning

gavanderhoorn commented 10 years ago

Well, naming is rather personal :). Maybe make a list with some alternatives. My suggestion: MoveItCartesianPlanning.

Perhaps even don't include the MoveIt prefix, as the 'official' MotionPlanning moveit rviz plugin also does not have it.

rkojcev commented 10 years ago

:D I have always been bad name giver :) CartesianPlanning sounds nice. Any other suggestions from the others are welcomed!!

rkojcev commented 10 years ago

After chatting with @shaun-edwards today we decided to rename the package and the panel as is in the ROS Wiki tutorials for the plugin.

rkojcev commented 10 years ago

Changed the name of the package to moveit_cartesian_plan_plugin and the panel to MoveIt Cartesian Plan Plug-in. The master branch is updated with this change.