ros-industrial-attic / workcell_explorer

Repository for GSoC 2018 focusing on creation of a ROS package for Robotic Workcell exploration
Apache License 2.0
11 stars 6 forks source link

Add README or Empty file #1

Closed aadityasaraiya closed 6 years ago

aadityasaraiya commented 6 years ago

Hey! This is the empty repository for my Google Summer of Code project on creation of a ROS Package for Robotic WorkCell Discovery. The abstract can be seen on this link.

Currently, the repository is empty. Can someone please add a blank README or a License file so that I can fork the repository and push the code with which I have been working with for this project.

Thanks! Aaditya Saraiya

gavanderhoorn commented 6 years ago

I'm willing to do that, but it's not necessary: just add https://github.com/ros-industrial/workcell_explorer.git as a remote to your local git repo.

This is also explained on the main repository page.

gavanderhoorn commented 6 years ago

Do make sure to add both a readme and the license file btw.

aadityasaraiya commented 6 years ago

Thanks for the advice @gavanderhoorn Will the license be the MIT license for this case?

gavanderhoorn commented 6 years ago

I'm not aware of what you discussed with your project coordinators (@Levi-Armstrong and Alex). Most software in ROS-Industrial is Apache 2 though.

Why do you believe it should be MIT?

aadityasaraiya commented 6 years ago

I haven't discussed this yet with @Levi-Armstrong. I was going through a few packages on ROS Industrial and most of them do seem to have BSD 3 or Apache 2. No specific reason for mentioning MIT. Should I keep it as Apache 2.0 and edit it after consulting with @Levi-Armstrong once?

I added https://github.com/ros-industrial/workcell_explorer.git as remote as follows git remote add origin https://github.com/ros-industrial/workcell_explorer.git and then followed with git push -u origin master.

However, I am getting remote: Permission to ros-industrial/workcell_explorer.git denied to aadityasaraiya. as I don't have permissions to upload to this repo.

Please do tell me if I am making some silly error.

gavanderhoorn commented 6 years ago

Let's keep at as Apache 2 for now. We can always change it later.

I've just invited you to the repository and given you write access.

aadityasaraiya commented 6 years ago

Sounds fair. Thanks again Gijs.

gavanderhoorn commented 6 years ago

It's somewhat off-topic, but I did not want to open a new issue for this.

If I may suggest:

aadityasaraiya commented 6 years ago
gavanderhoorn commented 6 years ago

@aadityasaraiya wrote:

An additional thing, the industrial_core and universal_robot packages are populated locally, however, in the repo, they are coming as blank folders. So I am just trying to figure that out as well.

that is just how submodules are represented by github.

But as I wrote earlier: don't use them. There's no need and they can be confusing.

aadityasaraiya commented 6 years ago

Thanks a lot. I found out that the blank folders are actually gitlinks to represent submodules. Using .rosinstall does make sense, so I will implement the same and avoid submodules.