search

ros-industrial-consortium / descartes

ROS-Industrial Special Project: Cartesian Path Planner
Apache License 2.0
127 stars 92 forks source link

descartes_tests package #202

Closed Jmeyer1292 closed 6 years ago

Jmeyer1292 commented 7 years ago

Following up on #198, this package:

Thanks again to @130s and @ipa-mdl for their help and hard-work with CI. I really appreciate it. Sorry I'm slow as molasses fixing this stuff.

mathias-luedtke commented 7 years ago

Great job! So you want to make CartesianRobot accessible to others? This will implicitly answer the meta-package and dependency questions..

Jmeyer1292 commented 6 years ago

@davetcoleman If I remember correctly, the industrial_ci package made a change a while back that forced its users to only use the ROS install space, so the only way two packages could share resources was through install rules. This meant that to have meaningful Descartes tests (where one needs a sample robot model to test planners or points), I would need to install test artifacts (like a dummy cartesian robot) or create a separate package that hosted them all. I picked the latter option for some reason.

130s commented 6 years ago

I also had a similar (but not the same) situation recently (in my case I used PKGS_DOWNSTREAM but this might not suit for this PR). Besides, I opened https://github.com/ros-industrial/industrial_ci/issues/231 for further improvement for this kind of situation.

davetcoleman commented 6 years ago

I would need to install test artifacts (like a dummy cartesian robot) or create a separate package that hosted them all. I picked the latter option for some reason.

You can still host your test data (similar to moveit_resources) in a test package, but have your tests located in their correct package location, right?

Jmeyer1292 commented 6 years ago

You can still host your test data (similar to moveit_resources) in a test package, but have your tests located in their correct package location, right? I don't really understand how this all works, but it looks like moveit resources are config files. What I'm talking about are C++ libraries. I can't test planners without installing test classes from previous packages.

Anyway, this whole test re-organization is just meant to ease the mental burden of pushing back into this repository. Wherever the tests are, they will still fail if something goes wrong. I will happily accept more pull requests to fix it how you want.