ros-industrial-consortium / descartes

ROS-Industrial Special Project: Cartesian Path Planner
Apache License 2.0
126 stars 92 forks source link

catkin packages can be improved #221

Closed VictorLamoine closed 6 years ago

VictorLamoine commented 6 years ago
./descartes_moveit
descartes_moveit: error: descartes_core plugin file 'moveit_adapter_plugins.xml' is not installed to ${CATKIN_PACKAGE_SHARE_DESTINATION}
descartes_moveit: CMakeLists.txt(25): error: catkin_package() lists 'rosconsole_bridge' as system package but it is not
descartes_moveit: CMakeLists.txt(6): notice: list COMPONENTS should be sorted
descartes_moveit: CMakeLists.txt(25): notice: use ${PROJECT_NAME} instead of 'descartes_moveit'
descartes_moveit: CMakeLists.txt(25): notice: list CATKIN_DEPENDS should be sorted
descartes_moveit: CMakeLists.txt(25): notice: list DEPENDS should be sorted
descartes_moveit: CMakeLists.txt(52): notice: use ${PROJECT_NAME} instead of 'descartes_moveit'
descartes_moveit: CMakeLists.txt(52): notice: list of source files should be sorted
descartes_moveit: CMakeLists.txt(58): notice: use ${PROJECT_NAME} instead of 'descartes_moveit'
catkin_lint: checked 1 packages and found 9 problems
./descartes_planner
descartes_planner: error: descartes_core plugin file 'descartes_planner_plugins.xml' is not installed to ${CATKIN_PACKAGE_SHARE_DESTINATION}
descartes_planner: notice: meaningless package description 'The descartes_planner package'
descartes_planner: CMakeLists.txt(6): notice: list COMPONENTS should be sorted
descartes_planner: CMakeLists.txt(33): notice: use ${PROJECT_NAME} instead of 'descartes_planner'
descartes_planner: CMakeLists.txt(33): notice: list CATKIN_DEPENDS should be sorted
descartes_planner: CMakeLists.txt(58): notice: use ${PROJECT_NAME} instead of 'descartes_planner'
descartes_planner: CMakeLists.txt(58): notice: list of source files should be sorted
descartes_planner: CMakeLists.txt(66): notice: use ${PROJECT_NAME} instead of 'descartes_planner'
descartes_planner: CMakeLists.txt(71): notice: use ${PROJECT_NAME} instead of 'descartes_planner'
descartes_planner: CMakeLists.txt(73): notice: use ${PROJECT_NAME} instead of 'descartes_planner'
catkin_lint: checked 1 packages and found 10 problems
./descartes_tests
descartes_tests: error: find_package(rostest) has no REQUIRED option
descartes_tests: CMakeLists.txt(74): error: missing test_depend on 'rostest'
descartes_tests: notice: package description starts with boilerplate 'A package'
catkin_lint: checked 1 packages and found 3 problems
./.git
catkin_lint: no packages to check
./descartes_core
descartes_core: notice: package description starts with boilerplate 'The descartes_core package'
descartes_core: CMakeLists.txt(6): notice: list COMPONENTS should be sorted
descartes_core: CMakeLists.txt(20): notice: use ${PROJECT_NAME} instead of 'descartes_core'
descartes_core: CMakeLists.txt(20): notice: list CATKIN_DEPENDS should be sorted
descartes_core: CMakeLists.txt(42): notice: use ${PROJECT_NAME} instead of 'descartes_core'
descartes_core: CMakeLists.txt(46): notice: use ${PROJECT_NAME} instead of 'descartes_core'
catkin_lint: checked 1 packages and found 6 problems
./descartes_trajectory
descartes_trajectory: CMakeLists.txt(82): error: missing test_depend on 'rosunit'
descartes_trajectory: notice: meaningless package description 'The descartes_trajectory package'
descartes_trajectory: CMakeLists.txt(24): notice: use ${PROJECT_NAME} instead of 'descartes_trajectory'
descartes_trajectory: CMakeLists.txt(24): notice: list CATKIN_DEPENDS should be sorted
descartes_trajectory: CMakeLists.txt(48): notice: use ${PROJECT_NAME} instead of 'descartes_trajectory'
descartes_trajectory: CMakeLists.txt(48): notice: list of source files should be sorted
descartes_trajectory: CMakeLists.txt(55): notice: use ${PROJECT_NAME} instead of 'descartes_trajectory'
descartes_trajectory: CMakeLists.txt(84): notice: use ${PROJECT_NAME} instead of 'descartes_trajectory'
catkin_lint: checked 1 packages and found 8 problems
./descartes_utilities
descartes_utilities: notice: package description starts with boilerplate 'This package contains'
descartes_utilities: CMakeLists.txt(12): notice: use ${PROJECT_NAME} instead of 'descartes_utilities'
catkin_lint: checked 1 packages and found 2 problems
./descartes
descartes: notice: package description starts with boilerplate 'Descartes is a'
catkin_lint: checked 1 packages and found 1 problems

A simple script to run catkin_lint in all directories of the project:

#!/bin/bash
for f in `find . -maxdepth 1 -mindepth 1 -type d`; do
  echo "$f"
  cd "$f"
  catkin_lint -W2 .
  cd ..
done