ros-industrial-consortium / descartes

ROS-Industrial Special Project: Cartesian Path Planner
Apache License 2.0
126 stars 92 forks source link

kinetic-devel branch build error due to "logError" function #226

Closed JeroenDM closed 6 years ago

JeroenDM commented 6 years ago

I tried to build descartes on a clean installation of ROS kinetic and got the error:

/home/jeroendm/ros/ws_descartes/src/descartes/descartes_core/include/descartes_core/utils.h:83:63:
error: ‘logError’ was not declared in this scope
       logError("Invalid euler convention entry %i", convention);
                                                               ^
make[2]: *** [CMakeFiles/descartes_trajectory.dir/src/axial_symmetric_pt.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [CMakeFiles/descartes_trajectory.dir/src/trajectory.cpp.o] Error 1
make[1]: *** [CMakeFiles/descartes_trajectory.dir/all] Error 2
make: *** [all] Error 2

I noticed they have changed logError to CONSOLE_BRIDGE_logError in the console_bridge package.

If this has to be fixed, I will do so and create a pull request. Or should the function ROS_ERROR be used instead?

Or am I doing something wrong?

The complete error message can be found here.

ManMan88 commented 6 years ago

I also have the same issue (also for logInform). For now I replaced logError with ROS_ERROR and logInform with ROS_INFO and then it compiles.

BrettHemes commented 6 years ago

I noticed they have changed logError to CONSOLE_BRIDGE_logError in the console_bridge package.

Ouch, this hit us as well. I think the right way to proceed is to change all the calls to include new prefix. +1 to a PR (unless @Jmeyer1292 thinks otherwise)

Jmeyer1292 commented 6 years ago

I'm cool with that. I've been on travel for a bit and I won't be back till tonight.

JeroenDM commented 6 years ago

Apparently, I'm to slow, I just woke up this morning and the issue was fixed :) Thank you!