[Windows][melodic-devel] Windows\MSVC port

ros-industrial-consortium / descartes

ROS-Industrial Special Project: Cartesian Path Planner

Apache License 2.0

126 stars 92 forks source link

[Windows][melodic-devel] Windows\MSVC port #239

Open seanyen opened 5 years ago

seanyen commented 5 years ago

This is a change to enable descartes to build by MSVC toolchains with https://aka.ms/ros installation.

Fixed installation location to align with catkin guide.
Added necessary dllexport/dllimport for public interfaces.
Conditionally include TR1 headers by checking C++ standard version supported by compilers.
Favor C++11 attributes [[gnu::unused]].
Conditionally add compiler options -std=c++11 -Wall -Wextra by checking what compiler is in use.
Added missing eigen_conversions dependency since some cpp files consuming it. (e.g., ikfast_moveit_state_adapter.cpp.)

seanyen commented 5 years ago

The CI failure seems not to do with the change. The error message are as followed:

: GPG error: http://packages.ros.org/ros-shadow-fixed/ubuntu bionic InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY F42ED6FBAB17C654
E: The repository 'http://packages.ros.org/ros-shadow-fixed/ubuntu bionic InRelease' is not signed.
The command '/bin/sh -c sed -i "/^# deb.*multiverse/ s/^# //" /etc/apt/sources.list     && apt-get update -qq     && apt-get -qq install --no-install-recommends -y         build-essential         python-catkin-tools         python-pip         python-rosdep         python-wstool         ros-melodic-catkin         ssh-client     && apt-get clean     && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
Function 'prepare_docker_image' returned with code '100' after 0 min 25 sec
The command "source .ci_config/travis.sh" exited with 100.

seanyen commented 5 years ago

@jrgnicho Hope I am pinging the correct owner. Any feedback would be appreciated!

gavanderhoorn commented 5 years ago

I've restarted the build.

This is most likely due to the recent key change.

seanyen commented 5 years ago

@gavanderhoorn @jrgnicho Sorry to ping again. Any chance to take a look and make this PR move forward?

gavanderhoorn commented 4 years ago

@seanyen: apologies, I was not notified of this for some reason.

I'm actually not a maintainer here. Most changes look like they're simple enough, so a review should be easy.

@jrgnicho: ping.