ros-industrial-consortium / godel

ROS-Industrial Focused Technical Project: Robotic Blending
77 stars 48 forks source link

Simple gui automation #220

Closed AustinDeric closed 7 years ago

AustinDeric commented 7 years ago

DO NOT MERGE

This PR eliminates error windows if no plans or surfaces are selected with the simple gui. Instead the user is informed that pressing next will select all plans or surfaces.

AustinDeric commented 7 years ago

Ready to be merged. The code is tested and works well. The status menus should display more informative messages about the current state.

jrgnicho commented 7 years ago

Do the changes here alter the behavior of the Simple GUI or just adds a new automatic mode?

AustinDeric commented 7 years ago

They alter the behavior in only the following ways:

In effect, this allows the user to press next and successfully perform all paths on all surfaces.

jrgnicho commented 7 years ago

@AustinDeric The way the the simple GUI works now forces the user to pay attention to what's happening at each stage in the process and so be more aware of any poorly segmented surfaces (if any) or and risky robot motions. I think that just allowing the user to mindlessly press the next button in order to get the robot to move could be unsafe.

AustinDeric commented 7 years ago

I agree, and mention above, that further information should be given for user awareness. In terms of unsafe path plans, we are still simulating all the motion prior to execution, so we are as safe as before.

At a high-level this new functionality is similar to that available in the admin gui because now the user can easily select all plans and surfaces.