search

ros-industrial-consortium / godel

ROS-Industrial Focused Technical Project: Robotic Blending
77 stars 48 forks source link

Fix deps #238

Closed hsd-dev closed 6 years ago

hsd-dev commented 6 years ago

Fix for Cannot locate rosdep definition for [godel_path_planning] and for cannot convert ‘moveit::planning_interface::MoveItErrorCode’ to ‘bool’

AustinDeric commented 6 years ago

+1 this works for me, travis looks good and code change looks good. It turns out i still have merge privileges, should i go ahead and merge?

Speaking of deps, godel still depends on @Jmeyer1292's descartes "godel_refactor_omp" branch. There is a newer branch at https://github.com/ros-industrial-consortium/descartes but that fails in the build with the following error:

godel/godel_process_planning/src/generate_motion_plan.cpp:79:47: error: no matching function for call to ‘descartes_planner::DAGSearch::run(std::vector<double>&)’
   double cost = search.run(process_start_costs);

If there is interest in using the newer version of descartes with godel, let me know and i will update. Thanks!

AustinDeric commented 6 years ago

I am going to merge this unless there are any objections...