search

ros-industrial / abb

ROS-Industrial ABB support (http://wiki.ros.org/abb)
146 stars 154 forks source link

Update visual meshes to collada file #117

Closed Levi-Armstrong closed 7 years ago

Levi-Armstrong commented 7 years ago

This PR update the visual meshes using a dae files with correct colors for the 2400 and 5400 to address issue #101.

Levi-Armstrong commented 7 years ago

@gavanderhoorn and @Jmeyer1292, Are either of you available to review this PR?

gavanderhoorn commented 7 years ago

Logistical: could you please rebase instead of merge? There is no history to preserve here and it makes the history of the repository much easier to follow without all those extra merge commits everywhere.

Levi-Armstrong commented 7 years ago

Logistical: could you please rebase instead of merge? There is no history to preserve here and it makes the history of the repository much easier to follow without all those extra merge commits everywhere.

Is using the GitHub squash and merge feature ok?

Levi-Armstrong commented 7 years ago

@gavanderhoorn, Is this PR ready to be merged?

gavanderhoorn commented 7 years ago

re: squash & merge: that is probably ok.

I'll test the changes on my Linux machine tomorrow.

Levi-Armstrong commented 7 years ago

Sound good. I used the original stl meshes and using blender added the color, then exported it as a dae.

gavanderhoorn commented 7 years ago

Just did a visual inspection.

Meshes look ok.

Did you do the all additional steps in Blender? I haven't compared with the old meshes, but I saw some sharp edges here and there which made me wonder.

Levi-Armstrong commented 7 years ago

Did you do the all additional steps in Blender? I haven't compared with the old meshes, but I saw some sharp edges here and there which made me wonder.

Yea, I imported the stl, then ran the modifier edge split, smooth shading, and applied the correct colors.

gavanderhoorn commented 7 years ago

I like that the meshes haven't increased too much in size (approx 650KB -> 950KB).