search

ros-industrial / abb

ROS-Industrial ABB support (http://wiki.ros.org/abb)
145 stars 152 forks source link

Increase minimum CMake version to allow builds on Focal Fossa (Noetic) #188

Closed ipa-nhg closed 2 years ago

ipa-nhg commented 2 years ago

Related to https://github.com/ros-industrial/ros_industrial_issues/issues/67

ipa-nhg commented 2 years ago

I don't know if these changes are appropriate for the current state of the repository, please review and decide if it makes sense, otherwise you can close the PR.

gavanderhoorn commented 2 years ago

Why would it not be appropriate?

ipa-nhg commented 2 years ago

The branch is kinetic-devel and there isn't a CI config for noetic. This was my criteria to add the disclaimer message...

gavanderhoorn commented 2 years ago

See #187. Working on it.

gavanderhoorn commented 2 years ago

Thanks :+1: