search

ros-industrial / abb

ROS-Industrial ABB support (http://wiki.ros.org/abb)
147 stars 156 forks source link

stop enforcing c++ 11 #192

Open cjue opened 1 year ago

cjue commented 1 year ago

Melodic defaults to C++14 already, ROS one requires C++ 17 due to log4cxx, so C++ 11 should not be enforced

gavanderhoorn commented 1 year ago

I see that same phrasing "all over" ROS-O related PRs.

That CMake setting doesn't just force C++11. It is a declaration the code in question has been tested to work and be correct for C++11 only.

It's unfortunate CMake doesn't allow version ranges, but I feel it's incorrect to misrepresent what that setting is for.

If you can assure me and the users here those plugins both compile and behave the same at runtime with other (ie: newer) versions of the C++ standard, we could merge.

Edit: but not in a branch called kinetic-devel, as that would not have the intended result.

cjue commented 1 year ago

Edit: but not in a branch called kinetic-devel, as that would not have the intended result.

so should there be a new melodic-devel or noetic-devel branch for this?