ros-industrial / abb

ROS-Industrial ABB support (http://wiki.ros.org/abb)
147 stars 156 forks source link

Update joint_names_irb5400.yaml #198

Open aaryanmurgunde opened 1 year ago

aaryanmurgunde commented 1 year ago

The URDF Provided has the these names set, and the name of the controller should match it, if not it gives an error saying "Joint_1 received but not found in the model".

gavanderhoorn commented 1 year ago

Thanks for the PR.

I'd rather do things the other way around: the xacro:macro should be updated to use the correct joint names.

Could you update your PR to:

thanks

gavanderhoorn commented 1 year ago

Any perticular reason why you want joint_N or just to maintain a standard ?

joint_N is the standard naming scheme for joints. Compare irb6600_225_255_macro.xacro, irb4400l_30_243_macro.xacro and irb2400_12_155_macro.xacro.

aaryanmurgunde commented 1 year ago

joint_N is the standard naming scheme for joints. Compare irb6600_225_255_macro.xacro, irb4400l_30_243_macro.xacro and irb2400_12_155_macro.xacro.

@gavanderhoorn Already updated here in the last commit.

aaryanmurgunde commented 1 year ago

Hi, @gavanderhoorn do you have an update on this ?